 |
 |
| Re: Problem fixed |
 |
 |
By axeld - Posted on December 21, 2004 - 23:34:49 (#15135)
Current version when comment was posted: 1.0.0 beta 4 |
 |
 |
a.k.a. Model.cpp version 1.4, almost 2 years old.
|
|
| Problem fixed |
 |
 |
By mmlr - Posted on December 21, 2004 - 19:49:23 (#15134)
Current version when comment was posted: 1.0.0 beta 4 |
 |
 |
The problem with the hanging recent items was caused by not setting the fStatus correctly, or more like not setting it at all in Model.cpp.
OpenNode is called from the copy constructor and fStatus is set to it's return value. But OpenNode itself does call OpenNodeCommon() (which is supposed to set fStatus), and returns fStatus then (instead of returning what OpenNodeCommon() returned).
For normal models this is no problem because fStatus is set in OpenNodeCommon(). But for kUnknownNode's the switch will fall to default and return B_ERROR - not setting fStatus.
There is a ToDo comment about this case, but it seems that OpenTracker didn't trigger it before.
To fix it, it is enough to set fStatus = B_ERROR before returning.
|
|
| Re: It seems a bug...but not in DiskProbe |
 |
 |
By axeld - Posted on December 19, 2004 - 08:35:09 (#15109)
Current version when comment was posted: 1.0.0 beta 4 |
 |
 |
I've investigated a bit, and it seems that BeOS automatically add recent files/folders for anything that goes through B_REFS_RECEIVED and your application - and since DiskProbe uses that mechanism internally as well, they show up there. So this is not strange, but natural, and I just didn't know about it :)
Since earlier Tracker versions did crash on devices, you'll experience what you described, while newer Tracker releases just ignore those entries. IIRC the fix was in Model.cpp.
Thanks a lot for having tested this! I'll just update the version information...
|
|
| Re: It seems a bug...but not in DiskProbe |
 |
 |
By zuMi - Posted on December 19, 2004 - 05:16:56 (#15105)
Current version when comment was posted: 1.0.0 beta 4 |
 |
 |
I've tried with the latest build of OT...an you're right!
No crashes, no freezes.
So I'll post this one on mlotz's forum.
Saluti et trigu
zuMi
|
|
| Re: It seems a bug...but not in DiskProbe |
 |
 |
By zuMi - Posted on December 19, 2004 - 04:51:08 (#15104)
Current version when comment was posted: 1.0.0 beta 4 |
 |
 |
I've tried with a plain PE, never upgraded or modified, used as distribuited from Be Inc with original Tracker, and with a PE+.01+.03+Bone with TNFS...unfortunally I've the same problem..Ive found this one in RosterSettings file
RecentDoc /dev/disk/floppy/raw "application/x-vnd.Haiku-DiskProbe" 32
|
|
| Re: It seems a bug...but not in DiskProbe |
 |
 |
By axeld - Posted on December 18, 2004 - 19:11:42 (#15097)
Current version when comment was posted: 1.0.0 beta 4 |
 |
 |
1) DiskProbe never tells the roster to remember opened files. If devices show up in the recent files list, something strange happens. What version of BeOS are you using?
2) That code is in Tracker, not in the Deskbar - it only uses it.
3) If the original Tracker does not work, it could also be an old bug that hasn't been fixed in Tracker.NewFS
4) Could you please try the standard OpenTracker and tell me if you experience the same problems?
5) The recent files are stored in config/settings/Roster/RosterSettings - but that won't help you since it will be read once, and written when you shutdown BeOS.
|
|
| Re: I seems a bug...but not in DiskProbe |
 |
 |
By zuMi - Posted on December 18, 2004 - 10:35:37 (#15093)
Current version when comment was posted: 1.0.0 beta 4 |
 |
 |
I don't think it's a TNFS fault, mlotz hasn't touched Deskbar code, in doubt I've restored the plain old R5 Tracker-Deskbar-libtracker.so, but I have the same problem, I must pay attention to avoid the Recent items or I'll have to kill Deskbar...can you tell me where are stored the recent opened documents ?
|
|
| Re: I seems a bug...but not in DiskProbe |
 |
 |
By axeld - Posted on December 18, 2004 - 08:19:37 (#15090)
Current version when comment was posted: 1.0.0 beta 4 |
 |
 |
Okay, I can't reproduce it at all. Can you please forward this bug report to the current Tracker.NewFS maintainer?
|
|
| Re: It seems to be a bug [WAS] Re : I seems a bug |
 |
 |
By zuMi - Posted on December 17, 2004 - 15:18:35 (#15083)
Current version when comment was posted: 1.0.0 beta 4 |
 |
 |
ok, open DP, choose from "Examine device" what you want ( for example /dev/disk/floppy/raw), then go to the Be Menu, go to "Recent Documents", this item will be highlighted but the Deskbar freezes, you'll must to kill it and restart the Desktop...
At this moment I'm using TNFS beta 6...
Ciao
zuMi
|
|
| Re: I seems a bug...but not in DiskProbe |
 |
 |
By axeld - Posted on December 17, 2004 - 08:54:25 (#15076)
Current version when comment was posted: 1.0.0 beta 4 |
 |
 |
Thanks for the note. Can you explain how I can reproduce this bug, and which version of Tracker/Deskbar you are using?
|
|
| I seems a bug...but not in DiskProbe |
 |
 |
By zuMi - Posted on December 17, 2004 - 08:44:23 (#15075)
Current version when comment was posted: 1.0.0 beta 4 |
 |
 |
if DiskProbe is used to probe a device, this action is registered in the recent actions, but if you go in the Be menu through recent documents or recent applications --> DiskProbe, the Deskbar freezes...
|
|
| bugreport |
 |
 |
By Diver - Posted on June 3, 2004 - 03:01:05 (#12681)
Current version when comment was posted: 1.0.0 beta 3 |
 |
 |
Hi, Axel!
*1. Moving through blocks on FAT32 partition using Alt+arrows eats a lot of cpu power while Be's DiskProbe not.
*2. Highlighting items in Attribures menu on mouse over doesn't work.
*3. Moving DiskProbe window around the screen takes to much cpu compared to R5 DiskProbe.
*4. Initial window with device selection popup shouldn't be resizable.
*5. Selection of serach mode in Find window should be made using radio button instead of popup menu for faster access.
*6. Typing hex values in find window have strange drawing artifacts with cursor placement/jumping.
*7. Resizing Find window leaves artifact at blue border.
*8. Case sensitive checkbox should be off by default.
*9. Dropped folders on the DiskProbe window shows alert window for every folder in selection insted of only one with message "Sorry, only files and devices can be opened.".
*10. Attribute editor window doesn't look nice.
*11. Many flickers while selecting in DataEditor.
*12. Feature request: dropping a file on the existing DiskProbe window with Shift holded should close old window and open new file.
*13. Feature request: Clipping.
*14. File->Open File... very often lockup DiskProbe and it crashed once with this sc:
loading symbols
segment violation occurred
BPrivate::Model::Model(BPrivate::Model const &):
__Q28BPrivate5ModelRCQ28BPrivate5Model:
+00d5 ec561a45: * 104a8b movl 0x00000010(%edx), %ecx
_Track_:sc
frame retaddr
fd0f0890 ec55679a BPrivate::ModelMenuItem::ModelMenuItem(BPrivate::Model const *, char const *, BMessage *, char, unsigned long, bool, bool) + 0000004e
fd0f08c0 ec59de88 BRecentItemsList::GetNextMenuItem(BMessage const *, BMessage const *, BHandler *, entry_ref *) + 000004e8
fd0f09a4 ec59f89c RecentItemsMenu::AddNextItem(void) + 00000078
fd0f09d4 ec5b0fb9 BPrivate::BSlowMenu::AddDynamicItem(BMenu::add_state) + 00000119
fd0f09f0 ec1ede09 BMenu::AttachedToWindow(void) + 000000cd
fd0f0a1c ec258682 BWindow::attach_builder(BView *) + 0000002a
fd0f0a34 ec244527 BView::AddChild(BView *, BView *) + 0000013f
fd0f0a58 ec1ef76e BMenu::_show(bool) + 00000152
fd0f0ac0 ec1ed223 BMenu::SelectItem(BMenuItem *, unsigned long, bool) + 00000073
fd0f0ae0 ec1f0810 BMenu::_track(int *, long) + 00000ef0
fd0f0c14 ec1f596e BMenuBar::Track(long *, long, bool) + 00000682
fd0f0cf0 ec1f5263 BMenuBar::TrackTask(void *) + 0000009f
fd0f0d3c ec06c50d thread_start + 00000039
_Track_:
|
|
| Re: "Open File" Bug |
 |
 |
By axeld - Posted on May 26, 2004 - 06:20:37 (#12586)
Current version when comment was posted: 1.0.0 beta 3 |
 |
 |
What Tracker version are you using? That menu is created using the standard BRecentFilesList class, and is implemented in Tracker.
It does work here without any problems using OpenTracker. Unfortunately, I can't remember having seen a fix for that very class, so unless you're using Zeta, I'm clueless.
|
|
| "Open File" Bug |
 |
 |
By Mahmoud - Posted on May 26, 2004 - 04:18:56 (#12582)
Current version when comment was posted: 1.0.0 beta 3 |
 |
 |
The program crashes if you have a file opened then choose File->Open File. This is an old bug from the previous version actually :)
|
|
| Re: Unresizable |
 |
 |
By axeld - Posted on March 10, 2004 - 12:25:33 (#11400)
Current version when comment was posted: 1.0.0 beta 2 |
 |
 |
Yes, that's a bug, and I haven't fixed it in this release yet, but it'll be in the final release. Thanks!
|
|
| Diskprobe crashes everytime I try to edit attributes |
 |
 |
By oxben - Posted on March 9, 2004 - 06:07:25 (#11389)
Current version when comment was posted: 1.0.0 beta |
 |
 |
Nice work!
I found a small issue in the program:
Everytime I try to edit an attribute from the Attributes menu, Diskprobe crashes.
I tried with different kind of files (binaries, text files, ...) and it never worked.
The BeOS version I use is 5.0.3 Pro Edition.
|
|
| Unresizable |
 |
 |
By 7 - Posted on March 6, 2004 - 16:21:48 (#11355)
Current version when comment was posted: 1.0.0 beta |
 |
 |
In the original DIskProbe, if you chose to view larger block sizes, you could resize the window to that size as well. This version does not allow making the window any larger.
Other than that, it looks very nice!
|
|
|
|
|